gaborkaszab commented on code in PR #6771:
URL: https://github.com/apache/iceberg/pull/6771#discussion_r1106881948
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -170,6 +170,8 @@ static CloseableIterable<FileScanTask>
planFiles(StaticTableScan scan) {
scan.filter(), transformedSpec, caseSensitive);
});
+ // Note, the delete files aren't applied to the data files so if there are
partition values that
+ // have been updated then both the 'old' and the 'new' values are present
in the output.
Review Comment:
Understood. I removed the comments from this file for now. However, I feel
that we should have a way somehow to document the behaviour of the metadata
table APIs that is not Spark specific. I'm open for suggestions, though, as I
don't want to duplicate the remarks on the
[Spark/Queries](https://iceberg.apache.org/docs/latest/spark-queries/#partitions)
page either, but in fact they might be useful in the PartitionsTable.java file
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
