sumeetgajjar commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1108847682
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -307,6 +353,30 @@ ManifestFile writeDeleteManifest(int newFormatVersion,
Long snapshotId, DeleteFi
return writer.toManifestFile();
}
+ InputFile writeManifestList(String compressionCodec, ManifestFile...
manifestFiles)
+ throws IOException {
+ File manifestListFile = temp.newFile();
+ Assert.assertTrue(manifestListFile.delete());
+ OutputFile outputFile =
+ org.apache.iceberg.Files.localOutput(
+ FileFormat.AVRO.addExtension(manifestListFile.toString()));
+
+ try (FileAppender<ManifestFile> writer =
+ ManifestLists.write(
+ formatVersion,
+ outputFile,
+ SNAPSHOT_ID,
+ SNAPSHOT_ID - 1,
+ formatVersion > 1 ? 34L : 0,
Review Comment:
`34L` was used as the sequence number in `TestManifestListVersions#SEQ_NUM`.
https://github.com/apache/iceberg/blob/085b556cca202db900755b7023e6d6aea0ae24fa/core/src/test/java/org/apache/iceberg/TestManifestListVersions.java#L49
Thus decided to use the same value for the newly added tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
