rdblue commented on code in PR #6850:
URL: https://github.com/apache/iceberg/pull/6850#discussion_r1108864320
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -263,9 +264,11 @@ public void renameTable(SessionContext context,
TableIdentifier from, TableIdent
client.post(paths.rename(), request, null, headers(context),
ErrorHandlers.tableErrorHandler());
}
- private LoadTableResponse loadInternal(SessionContext context,
TableIdentifier identifier) {
+ private LoadTableResponse loadInternal(
+ SessionContext context, TableIdentifier identifier, SnapshotLoading
snapshotLoading) {
Review Comment:
I think it would be much simpler to make this a catalog option that is set
as a boolean field or a local enum. That would require no changes to this
method definition and wouldn't require changing paths at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
