danielcweeks commented on code in PR #6850:
URL: https://github.com/apache/iceberg/pull/6850#discussion_r1110051023
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -18,17 +18,30 @@
*/
package org.apache.iceberg.rest;
+import java.util.Locale;
import java.util.Map;
import org.apache.iceberg.catalog.Namespace;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
public class ResourcePaths {
private static final Joiner SLASH = Joiner.on("/").skipNulls();
private static final String PREFIX = "prefix";
+ private static final String SNAPSHOT_LOADING_BEHAVIOR = "snapshot-loading";
Review Comment:
I put this in `ResourcePaths` because paths and params are related and all
part of the request URI. We can't build the full uri for a request because the
api for the `RESTClient` separates path and params. These are the params to
the load table path, so maybe it would be more clear if it were
`paths.tableParams()`? (this would correspond to the existing `params.table()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
