rdblue commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1114760916
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1515,4 +1599,46 @@ private RemoveSnapshots removeSnapshots(Table table) {
RemoveSnapshots removeSnapshots = (RemoveSnapshots)
table.expireSnapshots();
return (RemoveSnapshots)
removeSnapshots.withIncrementalCleanup(incrementalCleanup);
}
+
+ private StatisticsFile writeStatsFile(
+ long snapshotId, long snapshotSequenceNumber, String statsLocation,
FileIO fileIO)
+ throws IOException {
+ try (PuffinWriter puffinWriter =
Puffin.write(fileIO.newOutputFile(statsLocation)).build()) {
+ puffinWriter.add(
+ new Blob(
+ "some-blob-type",
+ ImmutableList.of(1),
+ snapshotId,
+ snapshotSequenceNumber,
+ ByteBuffer.wrap("blob
content".getBytes(StandardCharsets.UTF_8))));
+ puffinWriter.finish();
+
+ return new GenericStatisticsFile(
+ snapshotId,
+ statsLocation,
+ puffinWriter.fileSize(),
+ puffinWriter.footerSize(),
+ puffinWriter.writtenBlobsMetadata().stream()
+ .map(GenericBlobMetadata::from)
+ .collect(ImmutableList.toImmutableList()));
+ }
+ }
+
+ private StatisticsFile reuseStatsFile(long snapshotId, StatisticsFile
statisticsFile) {
+ return new GenericStatisticsFile(
+ snapshotId,
+ statisticsFile.path(),
+ statisticsFile.fileSizeInBytes(),
+ statisticsFile.fileFooterSizeInBytes(),
+ statisticsFile.blobMetadata());
+ }
+
+ private void commitStats(Table table, StatisticsFile statisticsFile) {
+ table.updateStatistics().setStatistics(statisticsFile.snapshotId(),
statisticsFile).commit();
Review Comment:
I find it odd that a single line like this is in a separate method. Seems
like this could be inlined and would make the tests more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
