krvikash commented on code in PR #6499:
URL: https://github.com/apache/iceberg/pull/6499#discussion_r1114899052
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##########
@@ -320,6 +326,57 @@ public void testAlreadyExistsException() {
() -> catalog.createTable(TABLE_IDENTIFIER, schema,
PartitionSpec.unpartitioned()));
}
+ @Test
+ public void testCreateTableCommitThrowsUnknownException()
+ throws TException, InterruptedException {
+ String namespace = DB_NAME;
+ String tableName = getRandomName();
+ TableIdentifier tableIdentifier = TableIdentifier.of(namespace, tableName);
+
+ HiveTableOperations hiveTableOperations =
+ (HiveTableOperations) catalog.newTableOps(tableIdentifier);
+
+ String tableLocation = catalog.defaultWarehouseLocation(tableIdentifier);
+ TableMetadata metadataV1 = createTableMetadata(tableLocation);
+
+ HiveTableOperations spyOps = spy(hiveTableOperations);
+ failCommitAndThrowException(spyOps);
+
+ Assertions.assertThatThrownBy(() -> spyOps.commit(null, metadataV1))
+ .isInstanceOf(RuntimeException.class)
+ .hasMessageContaining("Datacenter on fire");
+
+ Assert.assertEquals(
+ "One metadata files should exist",
+ 1,
+ metadataFileCount(tableLocation + "/writeMetaDataLoc"));
Review Comment:
> Why can not we use the metadataV1 and metadataFileCount(metadataV1)
Since the purpose of the test is to create a table, I am creating a new
`TableMetadata` object using the `createTableMetadata` method. However, this
method does not set the `metadataFileLocation` member variable of the
`TableMetadata` object. As a result, I cannot use the
`metadataFileCount(metadataV1)` method because it calls
`metadata.metadataFileLocation()`, which returns null.
> Could we just test the default Hive locations
I have to pass the metadata location to get the file count. metadata
location is specified in `createTableMetadata`.
I will try to see if we can use the existing `metadataFileCount(metadataV1)`
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
