rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1115098490
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java:
##########
@@ -595,12 +593,12 @@ public void testNaN() {
explainContainsPushDownAggregates = true;
}
- Assert.assertTrue(
- "explain should contain the pushed down aggregates",
explainContainsPushDownAggregates);
+ Assert.assertFalse(
Review Comment:
Yeah, not pushing when there are NaN values seems like a good idea. Spark
has different behavior than Trino in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
