amogh-jahagirdar commented on code in PR #6949:
URL: https://github.com/apache/iceberg/pull/6949#discussion_r1119320268
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -386,25 +386,28 @@ private void commitOperation(
String operatorId,
long checkpointId) {
LOG.info(
- "Committing {} for checkpoint {} to table {} with summary: {}",
+ "Committing {} for checkpoint {} to table {} branch {} with summary:
{}",
description,
checkpointId,
table.name(),
+ branch,
summary);
snapshotProperties.forEach(operation::set);
// custom snapshot metadata properties will be overridden if they conflict
with internal ones
// used by the sink.
operation.set(MAX_COMMITTED_CHECKPOINT_ID, Long.toString(checkpointId));
operation.set(FLINK_JOB_ID, newFlinkJobId);
operation.set(OPERATOR_ID, operatorId);
+ operation.toBranch(branch);
long startNano = System.nanoTime();
operation.commit(); // abort is automatically called if this fails.
long durationMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startNano);
LOG.info(
- "Committed {} to table: {}, checkpointId {} in {} ms",
+ "Committed {} to table: {}, branch: {}, checkpointId {} in {} ms",
Review Comment:
@stevenzwu I added this log for branch when backporting, noticed we were
missing the branch after the operation actually committed. I'll add this to
Flink 1.16 in a separate [PR](https://github.com/apache/iceberg/pull/6950). Let
me know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
