jackye1995 commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1120935454
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1112,6 +1112,15 @@ public <T extends S3ClientBuilder> void
applyS3SignerConfiguration(T builder) {
}
}
+ /**
+ * Get the AWS Credentials Provider based on the configured credential
properties.
+ *
+ * @return credential provider
+ */
+ AwsCredentialsProvider awsCredentialsProvider() {
+ return credentialsProvider(s3AccessKeyId, s3SecretAccessKey,
s3SessionToken);
Review Comment:
I am thinking should we treat the signer more like an AWS client and have
its own set of credential properties? It does not really have association with
S3 access credentials and it does not make much sense to reuse those property
values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
