dimas-b commented on code in PR #6789:
URL: https://github.com/apache/iceberg/pull/6789#discussion_r1122266599
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -194,7 +195,7 @@ protected TableOperations newTableOps(TableIdentifier
tableIdentifier) {
ContentKey.of(
org.projectnessie.model.Namespace.of(tableIdentifier.namespace().levels()),
tr.getName()),
- client.withReference(tr.getReference(), tr.getHash()),
+ refreshedClient().withReference(tr.getReference(), tr.getHash()),
Review Comment:
I believe in this case, since the client goes into `NessieTableOperations`,
its reference should be loaded immediately and made immutable regardless of
whether the commit hash is specified or not. Currently, the reference will be
loaded on first use, which may happen a lot later. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
