XN137 commented on code in PR #6982:
URL: https://github.com/apache/iceberg/pull/6982#discussion_r1122660030
##########
.github/workflows/java-ci.yml:
##########
@@ -87,7 +87,7 @@ jobs:
with:
distribution: zulu
java-version: 8
- - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest
+ - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest
--scan
Review Comment:
we are only using latest version of baseline which supported java 8:
https://github.com/apache/iceberg/blob/35692a360ffd2d1b9107ec6018f9fd97fda04671/build.gradle#L30-L34
in there we can find the checkstyle version:
https://github.com/palantir/gradle-baseline/blob/4.42.0/versions.props#L17
but i think 9.3 would be the last version with java8 support:
https://checkstyle.org/releasenotes.html#Release_9.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
