alaturqua commented on code in PR #6970:
URL: https://github.com/apache/iceberg/pull/6970#discussion_r1124985772
##########
python/pyiceberg/io/fsspec.py:
##########
@@ -112,8 +112,15 @@ def _s3(properties: Properties) -> AbstractFileSystem:
def _adlfs(properties: Properties) -> AbstractFileSystem:
from adlfs import AzureBlobFileSystem
- fs = AzureBlobFileSystem(**properties)
- return fs
+ return AzureBlobFileSystem(
+ connection_string=properties.get("adlfs.connection-string"),
+ account_name=properties.get("adlfs.account-name"),
+ account_key=properties.get("adlfs.account-key"),
+ sas_token=properties.get("adlfs.sas-token"),
+ tenant_id=properties.get("adlfs.tenant-id"),
+ client_id=properties.get("adlfs.client-id"),
+ client_secret=properties.get("adlfs.client-secret"),
+ )
SCHEME_TO_FS = {
Review Comment:
I think your changes are not pushed yet.
It looks like they only support:
- az
- abfs
- adl
https://github.com/fsspec/adlfs/blob/2d56e411906519f31ee614e601469f67845b41bd/docs/index.md#fsspec-protocols
I created an issue with question on their repository:
https://github.com/fsspec/adlfs/issues/403
I don't know, if they are supporting wasb implicitly. Would need to test. I
could take a look tomorrow or on monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
