danielcweeks commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1125711574
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -361,6 +383,55 @@ public void close() throws IOException {
httpClient.close(CloseMode.GRACEFUL);
}
+ public static HTTPClient buildFrom(Map<String, String> properties) {
Review Comment:
I went back and changed the builder to accept properties because that was
easier than updating how the S3V4 signer injects the object map. I don't love
that we've got multiple levels of builder pattern going on, but now that we
pass in the properties, we can extract values out of that as needed going
forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
