wangyinsheng commented on code in PR #7014:
URL: https://github.com/apache/iceberg/pull/7014#discussion_r1127857242
##########
api/src/main/java/org/apache/iceberg/metrics/MetricsReporter.java:
##########
@@ -18,10 +18,23 @@
*/
package org.apache.iceberg.metrics;
+import java.util.Map;
+
/** This interface defines the basic API for reporting metrics for operations
to a Table. */
@FunctionalInterface
public interface MetricsReporter {
+ /**
+ * Initialize a MetricsReporter with catalog properties.
+ *
+ * <p>A custom MetricsReporter implementation must have a no-arg
constructor. After initialize the
Review Comment:
done
##########
api/src/main/java/org/apache/iceberg/metrics/MetricsReporter.java:
##########
@@ -18,10 +18,23 @@
*/
package org.apache.iceberg.metrics;
+import java.util.Map;
+
/** This interface defines the basic API for reporting metrics for operations
to a Table. */
@FunctionalInterface
public interface MetricsReporter {
+ /**
+ * Initialize a MetricsReporter with catalog properties.
+ *
+ * <p>A custom MetricsReporter implementation must have a no-arg
constructor. After initialize the
+ * MetricsReporter without any arguments, this method should be called to
complete MetricsReporter
+ * initialization with catalog properties.
+ *
+ * @param properties catalog properties
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
