rdblue commented on code in PR #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r1129888032
##########
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##########
@@ -139,9 +213,16 @@ public static List<DataFile> listPartition(
buildDataFile(fileStatus.get(index), partitionKey, spec,
metrics, "orc");
});
} else {
- throw new UnsupportedOperationException("Unknown partition format: " +
format);
+ if (skipOnError) {
+ LOG.warn("Skipping unknown partition format: {} - {}", format,
partitionUri);
+ } else {
+ throw new UnsupportedOperationException(
+ String.format(
+ "Unknown partition format: %s - %s, set skip_on_error=true
to skip it.",
Review Comment:
This isn't the correct place to instruct the caller about how to avoid the
error. This can be used through different paths, but only the procedure has
`skip_on_error`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
