ajantha-bhat commented on code in PR #6091: URL: https://github.com/apache/iceberg/pull/6091#discussion_r1131436371
########## core/src/main/java/org/apache/iceberg/actions/BaseExpireSnapshotsActionResult.java: ########## @@ -18,6 +18,8 @@ */ package org.apache.iceberg.actions; +/** @deprecated will be removed in 2.0.0. */ +@Deprecated Review Comment: True. It is minor version removal as per [this](https://github.com/apache/iceberg/blob/3490db061c6adb300d0d0aaf27bae60c531359e1/CONTRIBUTING.md#semantic-versioning) I followed some wrong example from the same module (https://github.com/apache/iceberg/blame/master/core/src/main/java/org/apache/iceberg/BaseMetadataTable.java#L111) ########## core/src/main/java/org/apache/iceberg/actions/BaseExpireSnapshotsActionResult.java: ########## @@ -18,6 +18,8 @@ */ package org.apache.iceberg.actions; +/** @deprecated will be removed in 2.0.0. */ +@Deprecated Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
