singhpk234 commented on code in PR #7068:
URL: https://github.com/apache/iceberg/pull/7068#discussion_r1132919112
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java:
##########
@@ -167,6 +167,11 @@ public Identifier ident(ProcedureParameter param) {
return catalogAndIdent.identifier();
}
+ public Identifier ident(ProcedureParameter param, CatalogPlugin
defaultCatalog) {
Review Comment:
Agree, by above, I meant that modifying this function to just get identifier
from `ident(ProcedureParameter param, CatalogPlugin defaultCatalog)` and keep
the assertion as it is, hence specifically line 158.
---
> However, I changed the code a bit to share more. @singhpk234, could you
take another look?
+1 This looks great !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
