stevenzwu commented on code in PR #7070:
URL: https://github.com/apache/iceberg/pull/7070#discussion_r1133011026
##########
docs/flink-getting-started.md:
##########
@@ -747,8 +724,8 @@ DataStream<org.apache.avro.generic.GenericRecord>
dataStream = ...;
Schema icebergSchema = table.schema();
-// if the Iceberg table schema contains time fields, we can't use
-// Avro schema converted from Iceberg schema via AvroSchemaUtil.
+// if the Iceberg table schema contains time fields, and can't use
+// the Avro schema converted from Iceberg schema via AvroSchemaUtil.
Review Comment:
nit: seems odd syntax. maybe `the Avro schema converted from Iceberg schema
can't be used due to precision difference between how Iceberg schema (micro)
and Flink {@link AvroToRowDataConverters} (milli) deal with time type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
