snazy commented on code in PR #6789:
URL: https://github.com/apache/iceberg/pull/6789#discussion_r1137051869
##########
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java:
##########
@@ -60,6 +60,8 @@ public String getHash() {
return reference.getHash();
}
+ /** @deprecated will be removed in 1.3.0 */
+ @Deprecated
Review Comment:
What's calling this one?
##########
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java:
##########
@@ -60,6 +60,8 @@ public String getHash() {
return reference.getHash();
}
+ /** @deprecated will be removed in 1.3.0 */
+ @Deprecated
public Branch getAsBranch() {
Review Comment:
Don't understand why the existing call sites are changed.
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -165,10 +166,10 @@ private TableIdentifier
toIdentifier(EntriesResponse.Entry entry) {
return TableIdentifier.of(elements.toArray(new String[elements.size()]));
}
- public IcebergTable table(TableIdentifier tableIdentifier) {
+ public IcebergTable table(TableIdentifier tableIdentifier, Reference ref) {
Review Comment:
This signature change with all the related changes makes the call sides more
complicated - hard to see a justification for that.
##########
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java:
##########
@@ -71,6 +73,15 @@ public Reference getReference() {
return reference;
}
+ public Reference getReferenceForApiRequest() {
Review Comment:
What's the point of returning a `Branch` object as a `Reference` if the
hash's always `null`? I suspect, there's a simpler way to just use the
reference name, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
