lirui-apache commented on code in PR #6698:
URL: https://github.com/apache/iceberg/pull/6698#discussion_r1144364243
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -119,6 +119,26 @@ private CatalogProperties() {}
"client.pool.cache.eviction-interval-ms";
public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(5);
+ /**
+ * A comma separated list of elements used, in addition to the hive
metastore uri, to compose the
Review Comment:
I agree `CatalogProperties` may not be the best place for the config, but we
also have `CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS` here which is also specific
to `CachedClientPool`.
I think it's more consistent and intuitive to keep such configs in the same
place because they both configures the cache behavior. And I don't see why TTL
is more generic than the key when you're using a cache. So I prefer to leave it
here for now. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
