szehon-ho commented on code in PR #6698:
URL: https://github.com/apache/iceberg/pull/6698#discussion_r1145201454
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -119,6 +119,26 @@ private CatalogProperties() {}
"client.pool.cache.eviction-interval-ms";
public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(5);
+ /**
+ * A comma separated list of elements used, in addition to the hive
metastore uri, to compose the
Review Comment:
Yea as I mentioned, I also saw other cached flags currently used by Hive in
this file, but I feel they are more generic.
The reason I felt its more specific than ttl is its javadoc, it looks quite
Hive-specific (mention hive metastore uri, ugi, conf). Maybe we can fix that
instead then, though was not sure how, so hence the suggestion to move. Maybe
if you feel strongly, we can put the note "for Hive Catalog, the following keys
are supported.."?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
