jackye1995 commented on issue #7160:
URL: https://github.com/apache/iceberg/issues/7160#issuecomment-1480330202
Yes we definitely want to convert module by module.
I do not have strong opinion regarding using Junit `assertEquals` vs
AssertJ, it seems like they will incur almost the same amount of changes:
```
Assertions.assertThat("a").isEqualTo("b").describedAs("xxx");
```
vs
```
Assertions.assertEquals("a", "b", "xxx")
```
AssertJ might have the advantage that it can format the description with
`.describedAs("xxx %s %s", x, y)` so it's a bit easier to use. And it might
simplify some test cases. I don't quite get why we want to lazily load a
description message with the feature that Junit5 provides. So maybe using
AssertJ could be preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
