jackye1995 commented on code in PR #7185:
URL: https://github.com/apache/iceberg/pull/7185#discussion_r1146354615


##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryOutputFile.java:
##########
@@ -30,7 +33,7 @@ public class InMemoryOutputFile implements OutputFile {
 
   private boolean exists = false;
   private ByteArrayOutputStream contents;
-  private InMemoryFileIO parentFileIO;
+  private final InMemoryFileIO parentFileIO;

Review Comment:
   nit: can we place final variables over non final ones



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to