ChristinaTech commented on code in PR #7198:
URL: https://github.com/apache/iceberg/pull/7198#discussion_r1151304377
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/GlueTestBase.java:
##########
@@ -83,13 +82,7 @@ public static void beforeClass() {
AwsProperties properties = new AwsProperties();
properties.setS3FileIoDeleteBatchSize(10);
glueCatalog.initialize(
- catalogName,
- testBucketPath,
- properties,
- glue,
- LockManagers.defaultLockManager(),
- fileIO,
- ImmutableMap.of());
+ catalogName, testBucketPath, properties, glue, null, fileIO,
ImmutableMap.of());
Review Comment:
I was and still am on the fence about removing the `InMemoryLockManager`
being used here, but considering it hides the existence of Table-corrupting
bugs from the integ tests, leaned towards doing so. I would like to get other
opinions on whether this is the right call, and if not, how we will make sure
that this kind of issue has enough testing coverage going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
