jackye1995 commented on code in PR #7198: URL: https://github.com/apache/iceberg/pull/7198#discussion_r1161873678
########## aws/src/main/java/org/apache/iceberg/aws/util/RetryDetector.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.aws.util; + +import java.util.concurrent.atomic.AtomicBoolean; +import software.amazon.awssdk.core.metrics.CoreMetric; +import software.amazon.awssdk.metrics.MetricCollection; +import software.amazon.awssdk.metrics.MetricPublisher; + +/** + * Metrics are the only reliable way provided by the AWS SDK to determine if an API call was + * retried. This class can be attached to an AWS API call and checked after to determine if retries + * occurred. + */ +public class RetryDetector implements MetricPublisher { Review Comment: Given the fact that it has to be shared across different classes, and potentially attached to other things in the future, I am fine with it being public. We don't usually use Internal annotation in Iceberg, we can keep it as is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
