jackye1995 commented on code in PR #6862:
URL: https://github.com/apache/iceberg/pull/6862#discussion_r1176843082
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -300,6 +300,12 @@ public class AwsProperties implements Serializable {
public static final String DYNAMODB_TABLE_NAME_DEFAULT = "iceberg";
+ public static final String DYNAMODB_V2_SCHEMA_DEFAULT_TABLE_NAME =
"iceberg_dynamodb_v2";
+
+ public static final String DYNAMODB_CATALOG_SCHEMA_VERSION =
"dynamodb.catalog.schema-version";
+
+ public static final int DYNAMODB_DEFAULT_SCHEMA_VERSION = 1;
Review Comment:
I am thinking if we should just make it default to v2, since there is not
much users with prod dependencies of the Dynamo catalog as of now. Any
thoughts? @munendrasn @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
