RussellSpitzer commented on code in PR #7361:
URL: https://github.com/apache/iceberg/pull/7361#discussion_r1191713621


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -337,14 +337,21 @@ private Result doExecuteWithPartialProgress(
         commitManager.service(groupsPerCommit);
     commitService.start();
 
+    List<FileGroupFailureResult> rewriteFailures = 
Lists.newCopyOnWriteArrayList();

Review Comment:
   Just to note, I don't think we actually would have performance issues with 
copy on write array list, it just seems a bit wasteful to me in this context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to