hililiwei commented on code in PR #7382:
URL: https://github.com/apache/iceberg/pull/7382#discussion_r1198748058
##########
docs/flink-ddl.md:
##########
@@ -149,8 +149,11 @@ USE iceberg_db;
```sql
CREATE TABLE `hive_catalog`.`default`.`sample` (
id BIGINT COMMENT 'unique id',
- data STRING
-);
+ `data` STRING NOT NULL,
+ PRIMARY KEY(`id`) NOT ENFORCED
+)
+PARTITIONED BY (data)
+WITH ('format-version'='2', 'write.upsert.enabled'='true');
Review Comment:
We do not recommend enabling upsert in table properties:
https://iceberg.apache.org/docs/latest/flink-writes/#upsert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
