stevenzwu commented on code in PR #7866:
URL: https://github.com/apache/iceberg/pull/7866#discussion_r1240536180
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -105,18 +105,21 @@ public DynamicTableSource
createDynamicTableSource(Context context) {
@Override
public DynamicTableSink createDynamicTableSink(Context context) {
- ObjectPath objectPath = context.getObjectIdentifier().toObjectPath();
+ ObjectIdentifier objectIdentifier = context.getObjectIdentifier();
Review Comment:
thanks. I misunderstood the error msg earlier. I thought it is about Java
anonymous class and Java serialization. it is the unnamed `ObjectIdentifier`
with null catalog name. this change makes sense to me now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
