[ 
https://issues.apache.org/jira/browse/IGNITE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942618#comment-14942618
 ] 

Gianfranco Murador commented on IGNITE-429:
-------------------------------------------

Hello Chandresh, 
the code has been written correctly, 
can you please check these tips described by Anton ? 
Regards, Gianfranco

2) Redundant newlines should be removed. At code and imports.
3) Newlines should be added where it necessary:
for example:
Map<?, ?> res = process(tuple);
collector.emit(new Values(res));
5) @Override should be located according to Coding Guidelines.
6) Javadoc sentences should be finished with dot.


> Implement IgniteStormStreamer to stream data from Apache Storm
> --------------------------------------------------------------
>
>                 Key: IGNITE-429
>                 URL: https://issues.apache.org/jira/browse/IGNITE-429
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: streaming
>            Reporter: Dmitriy Setrakyan
>            Assignee: Chandresh Pancholi
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under 
> high load. It was previously named {{IgniteDataLoader}}, see ticket 
> IGNITE-394.
> See [Apache Storm|https://storm.apache.org/] for more information.
> We should create {{IgniteStormStreamer}} which will consume tuples from Storm 
> and stream them into Ignite caches. 
> More details to follow, but to the least we should be able to:
> - Convert/Intercept Storm tuples to Ignite data using an optional pluggable 
> converter.
> - Specify the cache name for the Ignite cache to load data into.
> - Specify other flags available on {{IgniteDataStreamer}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to