[ 
https://issues.apache.org/jira/browse/IGNITE-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046560#comment-15046560
 ] 

Alexey Kuznetsov commented on IGNITE-1371:
------------------------------------------

Igor, I do one more review round.
All my changes in ignite-1371-review3 branch (I deleted old review branches).

Take a look at my changes.

And I would like to ask you to rework tests to be subclassed from 
GridCommonAbstractTest and implement Cassandra aware descendant of 
GridAbstractCacheStoreSelfTest.
This will allow to remove usage of Log4J in tests in favor of IgniteLogger 
(GridCommonAbstractTest has all needed functionality out-of-the-box).

Also I noticed (and removed) checks for (log != null). Logger is injected by 
grid. In case of tests if you write test without node you may inject with help 
getTestResources().inject(store);
See CacheJdbcPojoStoreTest.

And also, please give an estimation when you are planning to finish with 
embedded Cassandra in tests.

> Key-Value store (like Cassandra) as CacheStore
> ----------------------------------------------
>
>                 Key: IGNITE-1371
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1371
>             Project: Ignite
>          Issue Type: New Feature
>          Components: cache
>    Affects Versions: ignite-1.4
>            Reporter: Alexandre Boudnik
>            Assignee: Igor Rudyak
>         Attachments: master_02b59e4_ignite-1371.patch
>
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> It will provide ability to map particular cache holding POJOs to Cassandra 
> table. Later it would be generalized to support eventually any any Key-Value 
> store.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to