[
https://issues.apache.org/jira/browse/IGNITE-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143347#comment-17143347
]
Denis A. Magda commented on IGNITE-13169:
-----------------------------------------
[~sdanilov],
The changes look reasonable to me. Thanks for improving the integration! I left
a couple of review notes in the pull-request.
Btw, will this improvement solve the other issue I reported earlier?
https://issues.apache.org/jira/browse/IGNITE-13029
It sounds like you hit the issue described in that ticket.
> Remove Ignite bean name requirement for Spring Data Repository
> --------------------------------------------------------------
>
> Key: IGNITE-13169
> URL: https://issues.apache.org/jira/browse/IGNITE-13169
> Project: Ignite
> Issue Type: Improvement
> Components: springdata
> Affects Versions: 2.8.1
> Reporter: Semyon Danilov
> Assignee: Semyon Danilov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> At the moment IgniteRepositoryFactoryBean requires Ignite instance bean (or
> IgniteConfiguration instance bean) with specific name.
> There are couple of problems with that behavior:
> 1) We have a SpringBoot autoconfiguration module which creates bean with
> different name, so Ignite Spring Data won't work out of the box
> 2) That is, actually, not a Spring-way to do things: Spring prefers
> injecting by class, qualifiers like name and order should be used only when
> necessay
> I propose changing behavior to "getting bean by class and not by name"
>
> This won't require any user code changes, because we only remove restrictions
> on Ignite instance bean name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
