[ https://issues.apache.org/jira/browse/IGNITE-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146658#comment-17146658 ]
Ignite TC Bot commented on IGNITE-12935: ---------------------------------------- {panel:title=Branch: [pull/7722/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/7722/head] Base: [master] : New Tests (11)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#00008b}PDS 2{color} [tests 3] * {color:#013220}IgnitePdsTestSuite2: IgniteWalRebalanceLoggingTest.testFullRebalanceLogMsgs - PASSED{color} * {color:#013220}IgnitePdsTestSuite2: IgniteWalRebalanceLoggingTest.testHistoricalRebalanceLogMsg - PASSED{color} * {color:#013220}IgnitePdsTestSuite2: IgniteWalRebalanceLoggingTest.testFullRebalanceWithShortCpHistoryLogMsgs - PASSED{color} {color:#00008b}Service Grid{color} [tests 4] * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=96c5501f271-66e9bc30-1170-484b-9193-d8f9cfd301fd, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=a304cc77-4e87-4ce2-b494-a989bf3ebf48, topVer=0, nodeId8=a304cc77, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593181559909]], val2=AffinityTopologyVersion [topVer=8179224952790605856, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=9b6e82d8-5428-41aa-a108-47cc665e6094, topVer=0, nodeId8=19cbc984, msg=, type=NODE_JOINED, tstamp=1593181559909], val2=AffinityTopologyVersion [topVer=-1440090742220744401, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=9b6e82d8-5428-41aa-a108-47cc665e6094, topVer=0, nodeId8=19cbc984, msg=, type=NODE_JOINED, tstamp=1593181559909], val2=AffinityTopologyVersion [topVer=-1440090742220744401, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=96c5501f271-66e9bc30-1170-484b-9193-d8f9cfd301fd, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=a304cc77-4e87-4ce2-b494-a989bf3ebf48, topVer=0, nodeId8=a304cc77, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593181559909]], val2=AffinityTopologyVersion [topVer=8179224952790605856, minorTopVer=0]]] - PASSED{color} {color:#00008b}Service Grid (legacy mode){color} [tests 4] * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=abd5e161-4ec6-4fdc-b350-86058cb1800c, topVer=0, nodeId8=40dcc9b2, msg=, type=NODE_JOINED, tstamp=1593181679755], val2=AffinityTopologyVersion [topVer=2068679071159579793, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=abd5e161-4ec6-4fdc-b350-86058cb1800c, topVer=0, nodeId8=40dcc9b2, msg=, type=NODE_JOINED, tstamp=1593181679755], val2=AffinityTopologyVersion [topVer=2068679071159579793, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=84d3111f271-9687f3aa-7b2b-4782-8da2-1f301caf60e5, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=719469e6-3ad6-4407-be76-fee0a142a03c, topVer=0, nodeId8=719469e6, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593181679755]], val2=AffinityTopologyVersion [topVer=-4572596404447967496, minorTopVer=0]]] - PASSED{color} * {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=84d3111f271-9687f3aa-7b2b-4782-8da2-1f301caf60e5, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=719469e6-3ad6-4407-be76-fee0a142a03c, topVer=0, nodeId8=719469e6, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593181679755]], val2=AffinityTopologyVersion [topVer=-4572596404447967496, minorTopVer=0]]] - PASSED{color} {panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5419518&buildTypeId=IgniteTests24Java8_RunAll] > Disadvantages in log of historical rebalance > -------------------------------------------- > > Key: IGNITE-12935 > URL: https://issues.apache.org/jira/browse/IGNITE-12935 > Project: Ignite > Issue Type: Improvement > Reporter: Vladislav Pyatkov > Assignee: Vladislav Pyatkov > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > # Mention in the log only partitions for which there are no nodes that suit > as historical supplier > For these partitions, print minimal counter (since which we should perform > historical rebalancing) with corresponding node and maximum reserved counter > (since which cluster can perform historical rebalancing) with corresponding > node. > This will let us know: > ## Whether history was reserved at all > ## How much reserved history we lack to perform a historical rebalancing > ## I see resulting output like this: > {noformat} > Historical rebalancing wasn't scheduled for some partitions: > History wasn't reserved for: [list of partitions and groups] > History was reserved, but minimum present counter is less than maximum > reserved: [[grp=GRP, part=ID, minCntr=cntr, minNodeId=ID, maxReserved=cntr, > maxReservedNodeId=ID], ...]{noformat} > ## We can also aggregate previous message by (minNodeId) to easily find the > exact node (or nodes) which were the reason of full rebalance. > # Log results of {{reserveHistoryForExchange()}}. They can be compactly > represented as mappings: {{(grpId -> checkpoint (id, timestamp))}}. For every > group, also log message about why the previous checkpoint wasn't successfully > reserved. > There can be three reasons: > ## Previous checkpoint simply isn't present in the history (the oldest is > reserved) > ## WAL reservation failure (call below returned false) > {code:java} > chpEntry = entry(cpTs); > boolean reserved = cctx.wal().reserve(chpEntry.checkpointMark());// If > checkpoint WAL history can't be reserved, stop searching. > if (!reserved) > break;{code} > ## Checkpoint was marked as inapplicable for historical rebalancing > {code:java} > for (Integer grpId : new HashSet<>(groupsAndPartitions.keySet())) > if (!isCheckpointApplicableForGroup(grpId, chpEntry)) > groupsAndPartitions.remove(grpId);{code} -- This message was sent by Atlassian Jira (v8.3.4#803005)