[ 
https://issues.apache.org/jira/browse/IGNITE-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179244#comment-15179244
 ] 

Roman Shtykh commented on IGNITE-2710:
--------------------------------------

Anton,

Thanks for your comments! I have made the changes.

1) -> You are absolutely right. Externalizing _isValid_ is not needed here -- 
by the current logic the session is completely deleted from the cache, and when 
it is not found a new session is created. I think I will need to make _isValid_ 
transient then.

2) -> _HttpSession_ is an interface. I could not find a cleaner way, so I 
invalidate the gunuine session on every subsequent _getSession()_ if it is 
invalid.

3) -> Good point, thank you!

4) -> I was thinking of it too. But doing some investigations and looking at 
users' code at github, it looks like many users expects _null_. Tomcat produces 
_null_ too. Just want to be sure users won't be surprised switching to Ignite. 
What do you think?

> Session not unbind from current request after invoking 
> request.getSession().invalidate()
> ----------------------------------------------------------------------------------------
>
>                 Key: IGNITE-2710
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2710
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 1.5.0.final
>         Environment: java8, tomcat8
>            Reporter: YuxuanWang
>            Assignee: Roman Shtykh
>              Labels: community, session, user
>             Fix For: 1.6
>
>
> System.out.println(request.getSession().getId());
> request.getSession().invalidate();
> System.out.println(request.getSession().getId());
> getSession() although return the same session after the invalidation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to