[
https://issues.apache.org/jira/browse/IGNITE-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152148#comment-17152148
]
Ilya Kasnacheev commented on IGNITE-13219:
------------------------------------------
Hello!
It seems that you need to fix code style, otherwise tests will not run:
{code}
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:22:
Import statement for 'java.util.UUID' is in the wrong order. Should be in the
'STANDARD_JAVA_PACKAGE' group, expecting not assigned imports on this line.
[CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:24:
Import statement for 'org.apache.ignite.IgniteLogger' is in the wrong order.
Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on
this line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:25:
Import statement for
'org.apache.ignite.internal.util.tostring.GridToStringExclude' is in the wrong
order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned
imports on this line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:26:
Import statement for 'org.apache.ignite.internal.util.typedef.internal.A' is
in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not
assigned imports on this line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:27:
Import statement for 'org.apache.ignite.internal.util.typedef.internal.S' is
in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not
assigned imports on this line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:28:
Import statement for 'org.apache.ignite.internal.util.typedef.internal.U' is
in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not
assigned imports on this line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:29:
Import statement for 'org.apache.ignite.logger.LoggerNodeIdAware' is in the
wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not
assigned imports on this line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:30:
Import statement for 'org.jetbrains.annotations.Nullable' is in the wrong
order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned
imports on this line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:31:
Import statement for 'org.slf4j.Logger' is in the wrong order. Should be in
the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.
[CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:32:
Import statement for 'org.slf4j.LoggerFactory' is in the wrong order. Should
be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this
line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:33:
Import statement for 'org.slf4j.Marker' is in the wrong order. Should be in
the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.
[CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:34:
Import statement for 'org.slf4j.MarkerFactory' is in the wrong order. Should
be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this
line. [CustomImportOrder]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:52:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:53:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:54:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:188:
@Override annotation on a different line than the target method declaration!
[OverrideAnnotationOnTheSameLine]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:188:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:189:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:190:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:196:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:198:
@Override annotation on a different line than the target method declaration!
[OverrideAnnotationOnTheSameLine]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:198:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:199:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:200:1:
Line contains a tab character. [FileTabCharacter]
17:18:07
[ERROR]
/opt/buildagent/work/7bc1c54bc719b67c/modules/slf4j/src/main/java/org/apache/ignite/logger/slf4j/Slf4jLogger.java:201:1:
Line contains a tab character. [FileTabCharacter]
{code}
> Slf4jLogger does not implement the LoggerNodeIdAware interface.
> ---------------------------------------------------------------
>
> Key: IGNITE-13219
> URL: https://issues.apache.org/jira/browse/IGNITE-13219
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 2.8.1
> Reporter: YuJue Li
> Assignee: YuJue Li
> Priority: Minor
> Fix For: 2.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the scenario of ignite + slf4j + log4j2, the generated log file is named
> ignite-${sys:nodeId}.log, The reason for this problem is that Slf4jLogger
> does not implement the
> LoggerNodeIdAware interface.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
