[ https://issues.apache.org/jira/browse/IGNITE-13328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180493#comment-17180493 ]
Ivan Daschinskiy commented on IGNITE-13328: ------------------------------------------- [~vveider] [~agura] I strongly believe that we should revert changes also for ignitevisorcmd and sqline. While I understand the initial concerns about ignite.sh, but as for these utils, I simply do not. Can you explain why swallowing potential problems costs less than hypothetical problems with almost zero probability. > Control.sh bash script swallow return code of CommandHandler and always > return 0 > -------------------------------------------------------------------------------- > > Key: IGNITE-13328 > URL: https://issues.apache.org/jira/browse/IGNITE-13328 > Project: Ignite > Issue Type: Bug > Affects Versions: 2.8, 2.8.1 > Reporter: Ivan Daschinskiy > Assignee: Ivan Daschinskiy > Priority: Blocker > Fix For: 2.9 > > Time Spent: 10m > Remaining Estimate: 0h > > After merging > [IGNITE-12367|https://issues.apache.org/jira/browse/IGNITE-12367], > control.sh always return 0, despite the fact that CommandHandler returns > correct code. > For example: > Ignite 2.8.1 > {code} > Failed to execute baseline command='collect' > Latest topology update failed. > Connection to cluster failed. Latest topology update failed. > Command [BASELINE] finished with code: 2 > Control utility has completed execution at: 2020-08-05T15:01:34.123 > Execution time: 26627 ms > >>> echo $? > 0 > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)