[ https://issues.apache.org/jira/browse/IGNITE-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211713#comment-17211713 ]
Ignite TC Bot commented on IGNITE-13564: ---------------------------------------- {panel:title=Branch: [pull/8345/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/8345/head] Base: [master] : New Tests (1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#00008b}Basic 3{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5653554]] * {color:#013220}IgniteBasicWithPersistenceTestSuite: SystemWorkersBlockingTest.testSingleWorker_NotInInfiniteLoop - PASSED{color} {panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5653630&buildTypeId=IgniteTests24Java8_RunAll] > Improve SYSTEM_WORKER_BLOCKED reporting. > ---------------------------------------- > > Key: IGNITE-13564 > URL: https://issues.apache.org/jira/browse/IGNITE-13564 > Project: Ignite > Issue Type: Improvement > Affects Versions: 2.9, 2.8.1 > Reporter: Ivan Daschinskiy > Assignee: Ivan Daschinskiy > Priority: Major > Fix For: 2.10 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, reporting of system thread blocking has major drawbacks. > 1. As system worker blocking is detected by another thread, due to > implementation, failure handler receives not full information about problem. > In {{FailureContext}} we have only two fields -- {{type}} and {{err}}. > Throwable {{err}} is generated in thread-detector flow, so we lost a context > of main problem. > 2. Currently, due to implementation, we print not full stacktrace of blocking > thread in {{org.apache.ignite.internal.worker.WorkersRegistry#onIdle}}. > 3. Current approach doesn't work when there is one thread in registry, this > fact isn't checked and this can cause an infinite looping of single thread, > calling {{onIdle}} > This two drawbacks can lead to completely loss of information about blocking > system thread. > I suggests: > 1. Add another parameter in {{FailureContext}}, namely {{worker}} > 2. Fix threaddump printing. > 3. Add assertion when there is only one system thread in registry -- This message was sent by Atlassian Jira (v8.3.4#803005)