[
https://issues.apache.org/jira/browse/IGNITE-13366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212401#comment-17212401
]
Anton Kalashnikov commented on IGNITE-13366:
--------------------------------------------
In general, it looks good to me. But I have several questions:
* I noticed that you rewrite the file when a new record is added. Did you
think about copy-on-write approach with a temp file?
* Your maintenanceId is UUID right now. But maybe it is better to use something
more human-readable?
* You start the autoAction(mntcProcessor.prepareAndExecuteMaintenance();)
before the discovery is started. I don't have the right answer for it but do
you sure it is the right place for it? Don't we want to call this method in
another thread(not started one) after the node was entirely started?
* Do we want to add some version for the maintenance record store file? Maybe
we should add it to the name of the file?
> Special mode for maintenance of Ignite node. Employing Maintenance Mode for
> clearing corrupted PDS files.
> ---------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-13366
> URL: https://issues.apache.org/jira/browse/IGNITE-13366
> Project: Ignite
> Issue Type: New Feature
> Components: persistence
> Affects Versions: 2.8.1
> Reporter: Sergey Chugunov
> Assignee: Sergey Chugunov
> Priority: Critical
> Labels: IEP-53
> Fix For: 2.10
>
> Original Estimate: 168h
> Time Spent: 1h 40m
> Remaining Estimate: 166h 20m
>
> If node with persistence is stopped when WAL was disabled for a cache (no
> matters because of rebalancing in progress or by explicit user request) on
> next node start all data files of that cache are removed automatically and
> unconditionally.
> This behavior may be unexpected for users as they may not understand all
> consequences of disabling WAL locally (for rebalancing) or globally (via
> IgniteCluster API call). Also it is not smart enough as there is no point in
> deleting consistent data files.
> We should change this behavior to the following list: no automatic deletions
> whatsoever. If data files are consistent (equivalent to: no checkpoint was
> running when node was stopped) start up normally. If data files are
> corrupted, don't let the node start.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
