[ 
https://issues.apache.org/jira/browse/IGNITE-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228540#comment-17228540
 ] 

Ilya Kasnacheev edited comment on IGNITE-13686 at 11/9/20, 12:01 PM:
---------------------------------------------------------------------

No, I do not think we should remove this test. It is a good test. It caught a 
bug.

There is a bug in Disk Page Compression feature: when 
IGNITE_DEFAULT_DISK_PAGE_COMPRESSION is specified, it is applied to 
non-persistent regions and fails their usage.

The bug needs to be fixed. Possibly in this ticket. The only thing we could do 
right now is mark these tests as ignored, but it's hard to do since they're in 
a suite that only fails with specific parameters.


was (Author: ilyak):
No, I do not think we should remove this test. It is a good test. It caught a 
bug.

There is a bug in Disk Page Compression feature: when 
IGNITE_DEFAULT_DISK_PAGE_COMPRESSION is specified, it is applied to 
non-persistent regions and fail their usage.

The bug needs to be fixed. Possibly in this ticket. The only thing we could do 
right now is mark these tests as ignored, but it's hard to do since they're in 
a suite that only fails with specific parameters.

> Compression test become failed after IGNITE-13658.
> --------------------------------------------------
>
>                 Key: IGNITE-13686
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13686
>             Project: Ignite
>          Issue Type: Improvement
>          Components: data structures
>    Affects Versions: 2.9
>            Reporter: Stanilovsky Evgeny
>            Assignee: Stanilovsky Evgeny
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After [1] was merged persistent check become fail to pass
> {noformat}
>         if (diskPageCompression != DiskPageCompression.DISABLED) {
>             if (!cctx.dataRegion().config().isPersistenceEnabled())
>                 throw new IgniteCheckedException("Disk page compression makes 
> sense only with enabled persistence.");
> {noformat} I suggest to remove failed smoke tests : 
> IgnitePersistentStoreDataStructuresTest
> [1] https://issues.apache.org/jira/browse/IGNITE-13658



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to