[ https://issues.apache.org/jira/browse/IGNITE-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389916#comment-17389916 ]
Andrey Mashenkov edited comment on IGNITE-15025 at 7/29/21, 1:57 PM: --------------------------------------------------------------------- [~vveider] I have tried to run {{run.sh}} and got next output with no error: {noformat} ~/apache-ignite-3$ ./check-rules/maven-check-scripts/run.sh * Executing CheckDependencyAndPluginVersionsNotInParent.sh... * Executing CheckModulesInRootPomAreSorted.sh... {noformat} It is unclear if the result is ok or not. Obviously, it is NOT ok because (looking at {{run.sh}} code) more scripts are expected being executed. Thus, {{run.sh}} has silently failed on {{CheckModulesInRootPomAreSorted}}. Actually, I had no {{xpath}} in the PATH and may run {{run.sh}} from an arbitrary directory, and got no errors. I think it worth adding # a preliminary check to {{run.sh}} (at least) if {{xpath}} file is reachable/runnable or not. # a check if workdir is correct. E.g. {{pom.xml}} file is found. WDYT? was (Author: amashenkov): [~vveider] I have tried to run {{run.sh}} and got next output with no error: {noformat} ~/apache-ignite-3$ ./check-rules/maven-check-scripts/run.sh * Executing CheckDependencyAndPluginVersionsNotInParent.sh... * Executing CheckModulesInRootPomAreSorted.sh... {noformat} It is unclear if the result is ok or not. Obvoiusly, it is NOT ok because looking at {{run.sh}} code more scripts expected to be executed. Thus, {{run.sh}} has silently failed on {{CheckModulesInRootPomAreSorted}}. Actually, I had no {{xpath}} in the PATH and may run {{run.sh}} from an arbitrary directory, and got no errors. I think it worth adding # a preliminary check to {{run.sh}} (at least) if {{xpath}} file is reachable/runnable or not. # a check if workdir is correct. E.g. {{pom.xml}} file is found. WDYT? > Add Maven check scripts to VCS > ------------------------------ > > Key: IGNITE-15025 > URL: https://issues.apache.org/jira/browse/IGNITE-15025 > Project: Ignite > Issue Type: Improvement > Reporter: Peter Ivanov > Assignee: Peter Ivanov > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently, only TC has scripts for Maven checks which leads to several > problems: > # Developers can't use them to check code locally > # Scripts can be lost with TC in inaccurate configuration operation. > It is required to move scripts to Ignite's codebase and call them from TC > build. -- This message was sent by Atlassian Jira (v8.3.4#803005)