[ 
https://issues.apache.org/jira/browse/IGNITE-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Lapin updated IGNITE-15210:
-------------------------------------
    Description: 
According to 
[https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html] 
and 
[https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/AfterEach.html|https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html]
  both setUp and tearDown methods must not be private, however they are in some 
cases in our code.

Despite the fact that private seems to work fine, it's still better to follow 
documentation recommendations.

  was:According to 
[https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html] 
and 
[https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/AfterEach.html|https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html]
  both setUp and tearDown methods must not be private, however they are in some 
cases in our code.


> @AfterEach and @BeforeEach must not be private
> ----------------------------------------------
>
>                 Key: IGNITE-15210
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15210
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Alexander Lapin
>            Assignee: Alexander Lapin
>            Priority: Major
>              Labels: ignite-3
>
> According to 
> [https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html]
>  and 
> [https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/AfterEach.html|https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html]
>   both setUp and tearDown methods must not be private, however they are in 
> some cases in our code.
> Despite the fact that private seems to work fine, it's still better to follow 
> documentation recommendations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to