[
https://issues.apache.org/jira/browse/IGNITE-15439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418101#comment-17418101
]
Alexey Scherbakov commented on IGNITE-15439:
--------------------------------------------
Actually this bug doesn't affect raft correctness because this code should be
removed.
Nevertheless, LGTM to the changes
> [Ignite 3] Fix Errorprone errors in Raft module.
> ------------------------------------------------
>
> Key: IGNITE-15439
> URL: https://issues.apache.org/jira/browse/IGNITE-15439
> Project: Ignite
> Issue Type: Bug
> Reporter: Andrey Mashenkov
> Assignee: Andrey Mashenkov
> Priority: Blocker
> Labels: ignite-3
> Fix For: 3.0.0-alpha3
>
>
> Static analyzer tool Errorprone reports errors for few modules.
> -These errors are muted and must be fixed.-
> Let's fix error in Raft module.
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile
> (default-compile) on project ignite-raft: Compilation failure
> [ERROR]
> /home/amashenkov/work/apache-ignite-3/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java:[79,30]
> [CollectionIncompatibleType] Argument 'member.address()' should not be
> passed to this method; its type NetworkAddress is not compatible with its
> collection's type argument String
> [ERROR] (see
> https://errorprone.info/bugpattern/CollectionIncompatibleType)
> {code}
> See
> {code:java}
> @Override public void onDisappeared(ClusterNode member) {
> readyAddresses.remove(member.address());
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
