[ 
https://issues.apache.org/jira/browse/IGNITE-15348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444361#comment-17444361
 ] 

Maksim Timonin commented on IGNITE-15348:
-----------------------------------------

[~andydem] , hi!

There is a separated block related to whitespaces and symbols like \{, }, (, ) 
[1]. According to it there should not be space after ")": 

> Blanks space (1 space character) should be used before opening *(* or 
>{*}{{*}. *{* and *}* should always be the last tokens in the line (except for 
>the possible comments). However, blank space should not be used between the 
>method name and opening {*}({*}.

Also, it's historical practice, some of Ignite commiters require to avoid 
spaces after cast operations. 

 

[1]https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Whitespacesandemptylines

 

 

> Checkstyle should check whitespace after cast token. 
> -----------------------------------------------------
>
>                 Key: IGNITE-15348
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15348
>             Project: Ignite
>          Issue Type: New Feature
>            Reporter: Maksim Timonin
>            Assignee: Andrei Demidov
>            Priority: Major
>              Labels: newbie
>
> According to Ignite code style [1]  there shouldn't a whitespace after the 
> ")" token. Let's add check for that.
>  
> Solution is add the TYPECAST token to the NoWhitespaceAfter  module
> <module name="NoWhitespaceAfter">
>  <property name="tokens" value="AT, INC, DEC, UNARY_MINUS, UNARY_PLUS, BNOT, 
> LNOT, DOT, ARRAY_DECLARATOR,
>  INDEX_OP, METHOD_REF, TYPECAST"/>
> </module>
>  
> Also it is required to fix all issues within repo.
>  
> [1] 
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Whitespacesandemptylines



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to