[ 
https://issues.apache.org/jira/browse/IGNITE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447535#comment-17447535
 ] 

Vyacheslav Koptilin edited comment on IGNITE-15666 at 11/22/21, 5:34 PM:
-------------------------------------------------------------------------

Hi Nikita,

> I think this metric should not be used to calculate the average time. We can 
> have several backups, unstable topology, etc that will lead to a wrong value.
I think it does not matter, only one source of truth should be used and this 
source is the JCache API specification.

> batch remove time also count missed removals but by the JCache API 
> specification should not
And this is an issue that should be fixed instead of breaking the 
Cache#remove(Key) method, IMHO.


was (Author: slava.koptilin):
Hi Nikita,

> I think this metric should not be used to calculate the average time. We can 
> have several backups, unstable topology, etc ...
I think it does not matter, only one source of truth should be used and this 
source is the JCache API specification.

> batch remove time also count missed removals but by the JCache API 
> specification should not
And this is an issue that should be fixed instead of breaking the 
Cache#remove(Key) method, IMHO.

> The remove metric value is different for sync and async methods
> ---------------------------------------------------------------
>
>                 Key: IGNITE-15666
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15666
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Amelchev Nikita
>            Assignee: Amelchev Nikita
>            Priority: Major
>             Fix For: 2.12
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The remove metric value is different for sync and async methods.
> The following metrics are updated only if the key was exist for the sync 
> version:
> {noformat}
> RemoveTimeTotal
> RemoveTime
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to