[ 
https://issues.apache.org/jira/browse/IGNITE-15897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451746#comment-17451746
 ] 

Roman Puchkovskiy commented on IGNITE-15897:
--------------------------------------------

[~ascherbakov] Thanks for your review! I've made some fixes and left a few 
comments of my own. could you please take a look again?

> ServiceLoader integration into configuration
> --------------------------------------------
>
>                 Key: IGNITE-15897
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15897
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Ivan Bessonov
>            Assignee: Roman Puchkovskiy
>            Priority: Major
>              Labels: iep-55, ignite-3
>             Fix For: 3.0.0-alpha4
>
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> In order to decouple modules and provide more flexibility, it would be 
> helpful to provide certain extension points using standard ServiceLoader Java 
> API.
> For example, currently there's an explicit list of configuration roots, 
> extensions, validators, etc. in {{org.apache.ignite.internal.app.IgniteImpl}} 
> code. This can become a mess and is not extensible.
> New service interface should provide following objects:
>  * collection of configuration roots;
>  * collection of validators;
>  * collection of internal extensions;
>  * collection of polymorphic extensions.
> That's probably enough.
> There should be a piece of code in {{runner}} module or somewhere else that 
> aggregates this information from all available service loader of given 
> interface. Aggregated information can then be used to initialize 
> {{{}ConfigurationManager{}}}.
> Local and Distributed roots/extensions should be provided in different 
> instances, it's much easier this way for individual developers who will 
> implement these services.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to