[ https://issues.apache.org/jira/browse/IGNITE-15998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453071#comment-17453071 ]
Rodion Smolnikov commented on IGNITE-15998: ------------------------------------------- Now the commit looks good to me. Just a couple of mistape with messages. > Add separate configuration for system data region. > -------------------------------------------------- > > Key: IGNITE-15998 > URL: https://issues.apache.org/jira/browse/IGNITE-15998 > Project: Ignite > Issue Type: Improvement > Components: cache > Reporter: Eduard Rakhmankulov > Assignee: Eduard Rakhmankulov > Priority: Major > Fix For: 2.13 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > *AS IS* > Currently, Ignite users can control only two *system region* parameters: > *initialSize* and *maxSize.* These properties are managed by > DataStorageConfiguration, but same time default and user-specified regions > have *org.apache.ignite.configuration.DataRegionConfiguration* for > configuring them. It is not wise to use the same class for the {*}system > region{*}, because there are some restrictions the codebase is relying on, > but keeping to `drill new holes` in *DataStorageConfiguration* for the > *system region* is not good either. > > *TO BE* > Implement configuration class for systemDataRegion similar to > {*}org.apache.ignite.configuration.DataRegionConfiguration{*}, but with more > restricted options, ready to be added more on-demand. > Move systemRegionProperties from > *org.apache.ignite.configuration.DataStorageConfiguration* to own class. > > API changes: > # Declare deprecated: > ** > org.apache.ignite.configuration.DataStorageConfiguration#setSystemRegionInitialSize > ** > org.apache.ignite.configuration.DataStorageConfiguration#getSystemRegionInitialSize > ** > org.apache.ignite.configuration.DataStorageConfiguration#setSystemRegionMaxSize > ** > org.apache.ignite.configuration.DataStorageConfiguration#getSystemRegionMaxSize > # Add new methods: > ** > org.apache.ignite.configuration.DataStorageConfiguration#setSystemDataRegionConfiguration(SystemDataRegionConfiguration) > ** > org.apache.ignite.configuration.DataStorageConfiguration#getSystemDataRegionConfiguration > # Add new configuration class > org.apache.ignite.configuration.SystemDataRegionConfiguration -- This message was sent by Atlassian Jira (v8.20.1#820001)