[
https://issues.apache.org/jira/browse/IGNITE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466102#comment-17466102
]
Ivan Bessonov commented on IGNITE-16188:
----------------------------------------
Hi [~nizhikov], could you please explain the reason why singleton lists here
are so bad? Your new approach looks a bit over-engineered without proper
justification.
And second, why do we need two WAL record classes with the same record type?
This is very confusing. You could rather replace the type of "writeEntries"
from "List" to "Object" and store either data entry or the full list depending
on the amount of entries. This is a common approach and it wouldn't lead to
this amount of code. API changes would be minimal - just add methods like
"size()" and "firstDataEntry()" to "DataRecord" (+ a new constructor), that's
it.
Please reply, I'm really interested in the explanations for the changes. Thank
you!
> Eliminate creation of singleton list for DataRecord
> ---------------------------------------------------
>
> Key: IGNITE-16188
> URL: https://issues.apache.org/jira/browse/IGNITE-16188
> Project: Ignite
> Issue Type: Improvement
> Reporter: Nikolay Izhikov
> Assignee: Nikolay Izhikov
> Priority: Major
>
> For most DataRecord intermidiate {{Collections.singletonList}} created.
> It possible to eliminate this object with {{SingleDataRecord}},
> {{MultiDataRecord}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
