[ 
https://issues.apache.org/jira/browse/IGNITE-16852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522792#comment-17522792
 ] 

Maxim Muzafarov commented on IGNITE-16852:
------------------------------------------

[~namelchev] Can you review may changes?

> Ignite compatibility framework can exclude unnecessary jars from test java 
> process classpath
> --------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-16852
>                 URL: https://issues.apache.org/jira/browse/IGNITE-16852
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Mikhail Petrov
>            Assignee: Maxim Muzafarov
>            Priority: Major
>             Fix For: 2.14
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Ignite compatibility framework can exclude unnecessary jars from test java 
> process classpath. 
> Compatibility framework excludes from calsspath classes which versions were 
> explicitly specified. See 
> IgniteCompatibilityAbstractTest#getProcessProxyJvmArgs.
> The exclusion mechanism is based on the specified dependency names
> See IgniteCompatibilityAbstractTest#getExcluded
> Dependency#sourcePathTemplate
> Dependency#artifactPathTemplate
> Since we use the following condition to filter dependency from classpath
> {code:java}
>   if (excluded.stream().noneMatch(path::contains))
> {code}
> The following situation can occur:
> Assume that we have two dependencies with names 
> `spring` and `spring-data-commons`. `spring` dependency version is specified 
> explicitly and must be excluded. But since we check, if dependency jar path 
> CONTAINS Dependency#artifactPathTemplate result both `spring` and 
> `spring-data-commons` jars is excluded from the classpath.
> It can be fixed by attaching '/' to Dependency#artifactPathTemplate result. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to