[
https://issues.apache.org/jira/browse/IGNITE-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271109#comment-15271109
]
Igor Sapego commented on IGNITE-2805:
-------------------------------------
Vladimir, my comments:
1-2) Fixed.
3) I think we need separate page for C++ code guidelines so it would be easier
to resolve issues like that.
4) I believe that reference semantics are preferable over pointer semantics
whenever possible. References can not be null and gives clear image about
ownership. Pointers on other hand can be null, more probable to be dangling or
can even represent arrays. So I'd prefer to stick to references everywhere
where it is possible. I didn't change other functions in {{ignite_impl.h}}
because they were not affected. Maybe we need separate ticket for that.
5) Added synchronisation. I believe it's going to have better performance like
this. Do you have any objections?
6) Moved everything to transaction_consts.h.
7) There are no {{error}} argument in getter-methods. If we are going to add
checks and exception throwing to these methods they are going to become
significantly slower. Do you think we still need to do that?
8) Fixed.
9) Tranasaction is returned because it is the only option as we need to return
something. Documentation says that returned instance can be invalid. However,
there is now throwing version of this call as the result of fixing of 8.
10) Fixed.
11) Currently in progress.
> CPP: Implement transactions API for CPP client.
> -----------------------------------------------
>
> Key: IGNITE-2805
> URL: https://issues.apache.org/jira/browse/IGNITE-2805
> Project: Ignite
> Issue Type: Task
> Components: platforms
> Affects Versions: 1.5.0.final
> Reporter: Igor Sapego
> Assignee: Igor Sapego
> Fix For: 1.6
>
>
> We should implement Transactions API for Ignite C++.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
