[
https://issues.apache.org/jira/browse/IGNITE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556866#comment-17556866
]
Pavel Pereslegin commented on IGNITE-13510:
-------------------------------------------
[~RyzhovSV]
Sorry for the late response.
It's a great idea to combine snapshot commands (create/restore) to improve UX.
I think we will rework other restore commands in the near future to comply with
the following general syntax.
{noformat}
control.(sh|bat) --snapshot restore snapshot_name [--groups group1,...groupN]
[--src path] [--sync]
control.(sh|bat) --snapshot status
control.(sh|bat) --snapshot cancel --id=operationId
{noformat}
The operation ID is needed to avoid possible errors when canceling the
operation.
So we need to display this ID in status. I suggest to use first 4 bytes from
request UUID (as a hexadecimal value).
For example, for request ID "{*}f6b2ac51{*}-fa90-462e-85d3-caecdf6cc2f4" we can
display operation ID "{*}f6b2ac51{*}".
In addition, we should also display the "estimated" progress of the operation
(create/restore).
We can rely on the following metrics:
create: CurrentSnapshotTotalSize / CurrentSnapshotProcessedSize
restore: totalPartitions / processedPartitions
So from my point of view the status output should be something like:
{noformat}
Operation "f6b2ac51" to create/restore snapshot "snapshotName" is running on
the following nodes:
gridCommandHandlerTest0: 78% complete (estimated)
gridCommandHandlerTest1: 23% complete (estimated)
{noformat}
WDYT?
Do you plan to continue working on this patch?
> Getting status of snapshot execution via command line and jmx
> -------------------------------------------------------------
>
> Key: IGNITE-13510
> URL: https://issues.apache.org/jira/browse/IGNITE-13510
> Project: Ignite
> Issue Type: Task
> Reporter: Sergei Ryzhov
> Assignee: Sergei Ryzhov
> Priority: Major
> Labels: iep-43, ise, snapshot
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> the control.sh utility immediately relinquishes control
> and without using metricExporter it is impossible to understand whether the
> snapshot completed or not
> Restoring
> {code:java}
> Control utility [ver. 2.12.0-SNAPSHOT#20211004-sha1:77de60a7]
> 2021 Copyright(C) Apache Software Foundation
> User: sega
> Time: 2021-10-07T14:18:59.523
> Command [SNAPSHOT] started
> Arguments: --snapshot status --yes
> --------------------------------------------------------------------------------
> Status of SNAPSHOT operations:
> gridCommandHandlerTest0 -> Restoring to snapshot with name: snapshot_02052020
> gridCommandHandlerTest1 -> Restoring to snapshot with name: snapshot_02052020
> Command [SNAPSHOT] finished with code: 0
> Control utility has completed execution at: 2021-10-07T14:18:59.546
> Execution time: 23 ms
> {code}
> Creating
> {code:java}
> Control utility [ver. 2.12.0-SNAPSHOT#20211004-sha1:77de60a7]
> 2021 Copyright(C) Apache Software Foundation
> User: sega
> Time: 2021-10-07T14:18:55.368
> Command [SNAPSHOT] started
> Arguments: --snapshot status --yes
> --------------------------------------------------------------------------------
> Status of SNAPSHOT operations:
> gridCommandHandlerTest0 -> Creating the snapshot with name: snapshot_02052020
> gridCommandHandlerTest1 -> Creating the snapshot with name: snapshot_02052020
> Command [SNAPSHOT] finished with code: 0
> Control utility has completed execution at: 2021-10-07T14:18:55.391
> Execution time: 23 ms
> {code}
> No snapshot operation
> {code:java}
> Control utility [ver. 2.12.0-SNAPSHOT#20211004-sha1:77de60a7]
> 2021 Copyright(C) Apache Software Foundation
> User: sega
> Time: 2021-10-07T14:18:58.408
> Command [SNAPSHOT] started
> Arguments: --snapshot status --yes
> --------------------------------------------------------------------------------
> Status of SNAPSHOT operations:
> gridCommandHandlerTest0 -> No snapshot operation.
> gridCommandHandlerTest1 -> No snapshot operation.
> Command [SNAPSHOT] finished with code: 0
> Control utility has completed execution at: 2021-10-07T14:18:58.439
> Execution time: 31 ms
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
